feat: Add deregister_object_store
#17999
Open
+35
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
jonathanc-n
commented
Oct 9, 2025
|
|
||
| /// Deregister the store previously registered with the same key. Returns the | ||
| /// deregistered store if it existed. | ||
| fn deregister_store(&self, url: &Url) -> Result<Arc<dyn ObjectStore>>; |
There was a problem hiding this comment.
This is breaking, we can add a label. I'm thinking maybe we can have a default return value and remove it in another version but I don't know what would be a good default return value (I was thinking of just erroring).
There was a problem hiding this comment.
Do you mean that giving it a default value and letting users be aware of the new API in the next release, then removing the default value in the next release after next?
There was a problem hiding this comment.
Yes, but I am very open to doing it another way if there is a more standard way to deal with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?